Skip to content

Updating MemoryStore so it can support arrays.#17

Merged
jwoertink merged 3 commits intomainfrom
issues/15
Mar 12, 2026
Merged

Updating MemoryStore so it can support arrays.#17
jwoertink merged 3 commits intomainfrom
issues/15

Conversation

@jwoertink
Copy link
Member

Fixes #15

data = yield

if data.is_a?(Array)
if data.is_a?(Array(String)) || data.is_a?(Array(Int32)) || data.is_a?(Array(Int64)) || data.is_a?(Array(Float64)) || data.is_a?(Array(Bool))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this... I'd rather see something like CachableType or whatever, but Crystal gets a little weird with type aliases and such. This is fine enough for now

@jwoertink jwoertink merged commit 04e668a into main Mar 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory store as: Array(String) not work.

1 participant