Conversation
…cipient device Notifications were silently dropped when the admin had no paired device on the topic and TotalSent was zero without raising any error The server now logs a warning when a system notification reaches zero devices so the misconfiguration is visible in logs The admin UI also shows a warning when the configured recipient has no active device on the chosen topic so the issue is caught at setup time instead of through missing events later Save remains enabled intentionally so admins can enable notifications now and pair a device right after without being blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notifications were silently dropped when the admin had no paired device on the topic and TotalSent was zero without raising any error
The server now logs a warning when a system notification reaches zero devices so the misconfiguration is visible in logs
The admin UI also shows a warning when the configured recipient has no active device on the chosen topic so the issue is caught at setup time instead of through missing events later
Save remains enabled intentionally so admins can enable notifications now and pair a device right after without being blocked