Support Dotenv with quotes and nested quotes - #98
Merged
pedro merged 3 commits intoApr 26, 2017
Conversation
Contributor
Author
|
I'm no groovy/java developer, so I can't actually figure out the android code. I tried several ways to test JAVA regexes online but no real results. I think someone who knows how those work can easily take my pattern and apply it to the gradle script. |
|
You can escape quotes, that helped me passing JSON in. |
Contributor
|
You rock, thank you! |
Contributor
|
Ah hmm testing some stuff before releasing I noticed this dropped support for unquoted values (the 1st example in https://regex101.com/r/SLdbes/1). I made the quotes optional for now to not break existing apps. Do you think we should explicitly ignore these? |
pedro
added a commit
that referenced
this pull request
Apr 26, 2017
venus-heaven
pushed a commit
to venus-heaven/config-React-native
that referenced
this pull request
Mar 11, 2024
dev-arrow
added a commit
to dev-arrow/react-native-config
that referenced
this pull request
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #97
When parsing dotenv files, if there's any guide to follow, it's the defacto npm dotenv project
This PR implements a more sophisticated matching using a regular expression. This allows the parser to handle all the cases presented in the dotenv node package.