Refine logging #27
Merged
Refine logging #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly state what has been loaded, and show failures only upon a sufficient logging level, as they should not hamper correct operation
|
It looks good overall. Please give me a few days to look at the code overall again to make sure it makes sense, it's been a while! |
|
@uhoefel I updated your branch directly, please let me know if it answers your requirements as well. Thanks again for your contribution! If you're happy with it, I'll merge and trigger a release. |
|
Good changes, I am more than happy with this. Thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UncheckedIOExceptioninstead ofRuntimeExceptionfor a caught and rethrownIOException.Cf. #26