Skip to content

Refine logging #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 11, 2025
Merged

Refine logging #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ea9fbb5
bump JUnit version
uhoefel Sep 5, 2025
461f5b0
Refine logging
uhoefel Sep 5, 2025
e22dc3e
Use UncheckedIOException instead of RuntimeException for caught IOE
uhoefel Sep 5, 2025
0a205d1
Add the throwable to the fine grained logging message
uhoefel Sep 5, 2025
f275655
Fix logging for throwable info
uhoefel Sep 5, 2025
54f4f18
Fix whitespace
uhoefel Sep 5, 2025
d6d9955
Simplify dumping which blas/lapack/arpack we are using
luhenry Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arpack/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ information or have any questions.
<packaging>jar</packaging>

<properties>
<junit.version>5.8.2</junit.version>
<junit.version>5.13.4</junit.version>
<automatic.module.name>dev.ludovic.netlib.arpack</automatic.module.name>
</properties>

Expand Down
5 changes: 4 additions & 1 deletion arpack/src/main/java/dev/ludovic/netlib/arpack/InstanceBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

package dev.ludovic.netlib.arpack;

import java.util.logging.Level;
import java.util.logging.Logger;

final class InstanceBuilder {
Expand All @@ -39,6 +40,8 @@ final class InstanceBuilder {
nativeArpack = initializeNative();
javaArpack = initializeJava();
arpack = nativeArpack != null ? nativeArpack : javaArpack;

log.info("Using " + arpack.getClass().getName());
}

public static ARPACK arpack() {
Expand All @@ -49,7 +52,7 @@ private static NativeARPACK initializeNative() {
try {
return JNIARPACK.getInstance();
} catch (Throwable t) {
log.warning("Failed to load implementation from:" + JNIARPACK.class.getName());
log.log(Level.FINE, "Failed to load implementation from:" + JNIARPACK.class.getName(), t);
return null;
}
}
Expand Down
5 changes: 3 additions & 2 deletions arpack/src/main/java/dev/ludovic/netlib/arpack/JNIARPACK.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@

package dev.ludovic.netlib.arpack;

import java.io.InputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.UncheckedIOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
Expand Down Expand Up @@ -55,7 +56,7 @@ protected JNIARPACK() {
StandardCopyOption.REPLACE_EXISTING);
temp.toFile().deleteOnExit();
} catch (IOException e) {
throw new RuntimeException("Unable to load native implementation", e);
throw new UncheckedIOException("Unable to load native implementation", e);
}

System.load(temp.toString());
Expand Down
2 changes: 1 addition & 1 deletion blas/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ information or have any questions.
<packaging>jar</packaging>

<properties>
<junit.version>5.8.2</junit.version>
<junit.version>5.13.4</junit.version>
<automatic.module.name>dev.ludovic.netlib.blas</automatic.module.name>
</properties>

Expand Down
12 changes: 7 additions & 5 deletions blas/src/main/java/dev/ludovic/netlib/blas/InstanceBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

package dev.ludovic.netlib.blas;

import java.util.logging.Level;
import java.util.logging.Logger;

final class InstanceBuilder {
Expand All @@ -39,6 +40,8 @@ final class InstanceBuilder {
nativeBlas = initializeNative();
javaBlas = initializeJava();
blas = nativeBlas != null ? nativeBlas : javaBlas;

log.info("Using " + blas.getClass().getName());
}

public static BLAS blas() {
Expand All @@ -49,7 +52,7 @@ private static NativeBLAS initializeNative() {
try {
return JNIBLAS.getInstance();
} catch (Throwable t) {
log.warning("Failed to load implementation from:" + JNIBLAS.class.getName());
log.log(Level.FINE, "Failed to load implementation from:" + JNIBLAS.class.getName(), t);
return null;
}
}
Expand All @@ -69,16 +72,15 @@ private static JavaBLAS initializeJava() {
log.finest("trying to return java 16 instance");
return VectorBLAS.getInstance();
} catch (Throwable t) {
log.warning("Failed to load implementation from:" + VectorBLAS.class.getName());
log.log(Level.FINE, "Failed to load implementation from:" + VectorBLAS.class.getName(), t);
}
}
if (major >= 11) {
log.finest("return java 11 instance");
return Java11BLAS.getInstance();
} else {
log.finest("return java 8 instance");
return Java8BLAS.getInstance();
}
log.finest("return java 8 instance");
return Java8BLAS.getInstance();
}

public static JavaBLAS javaBlas() {
Expand Down
5 changes: 3 additions & 2 deletions blas/src/main/java/dev/ludovic/netlib/blas/JNIBLAS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@

package dev.ludovic.netlib.blas;

import java.io.InputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.UncheckedIOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
Expand Down Expand Up @@ -55,7 +56,7 @@ protected JNIBLAS() {
StandardCopyOption.REPLACE_EXISTING);
temp.toFile().deleteOnExit();
} catch (IOException e) {
throw new RuntimeException("Unable to load native implementation", e);
throw new UncheckedIOException("Unable to load native implementation", e);
}

System.load(temp.toString());
Expand Down
2 changes: 1 addition & 1 deletion lapack/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ information or have any questions.
<packaging>jar</packaging>

<properties>
<junit.version>5.8.2</junit.version>
<junit.version>5.13.4</junit.version>
<automatic.module.name>dev.ludovic.netlib.lapack</automatic.module.name>
</properties>

Expand Down
7 changes: 5 additions & 2 deletions lapack/src/main/java/dev/ludovic/netlib/lapack/InstanceBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

package dev.ludovic.netlib.lapack;

import java.util.logging.Level;
import java.util.logging.Logger;

final class InstanceBuilder {
Expand All @@ -39,6 +40,8 @@ final class InstanceBuilder {
nativeLapack = initializeNative();
javaLapack = initializeJava();
lapack = nativeLapack != null ? nativeLapack : javaLapack;

log.info("Using " + lapack.getClass().getName());
}

public static LAPACK lapack() {
Expand All @@ -49,14 +52,14 @@ private static NativeLAPACK initializeNative() {
try {
return JNILAPACK.getInstance();
} catch (Throwable t) {
log.warning("Failed to load implementation from:" + JNILAPACK.class.getName());
log.log(Level.FINE, "Failed to load implementation from:" + JNILAPACK.class.getName(), t);
return null;
}
}

public static NativeLAPACK nativeLapack() {
if (nativeLapack == null) {
throw new RuntimeException("Unable to load native implementation");
throw new RuntimeException("Unable to load native LAPACK implementation");
}
return nativeLapack;
}
Expand Down
6 changes: 4 additions & 2 deletions lapack/src/main/java/dev/ludovic/netlib/lapack/JNILAPACK.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
package dev.ludovic.netlib.lapack;

import java.io.InputStream;
import java.io.UncheckedIOException;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
Expand Down Expand Up @@ -55,10 +56,11 @@ protected JNILAPACK() {
StandardCopyOption.REPLACE_EXISTING);
temp.toFile().deleteOnExit();
} catch (IOException e) {
throw new RuntimeException("Unable to load native implementation", e);
throw new UncheckedIOException("Unable to load native implementation", e);
}

System.load(temp.toString());}
System.load(temp.toString());
}

public static NativeLAPACK getInstance() {
return instance;
Expand Down