Implement full Java BLAS and expand test coverage#35
Merged
Conversation
Replace remaining org.netlib.blas delegations in Java8BLAS with native Java implementations for symmetric, triangular, band matrix, and Level 1 operations. Add parameter validation to AbstractBLAS for dgbmv/sgbmv. Expand test suite across 41 test files with coverage for edge cases, non-unit strides, transpose variants, scaling factors, and drotmg/srotmg rescaling branches. Use relative tolerance for float tests where alpha amplifies values beyond absolute epsilon thresholds.
luhenry
force-pushed
the
no-f2j-for-blas
branch
from
8fc5412 to
b46e666
Compare
luhenry
added a commit
that referenced
this pull request
Feb 25, 2026
Replace remaining org.netlib.blas delegations in Java8BLAS with native Java implementations for symmetric, triangular, band matrix, and Level 1 operations. Add parameter validation to AbstractBLAS for dgbmv/sgbmv. Expand test suite across 41 test files with coverage for edge cases, non-unit strides, transpose variants, scaling factors, and drotmg/srotmg rescaling branches. Use relative tolerance for float tests where alpha amplifies values beyond absolute epsilon thresholds.
luhenry
added a commit
that referenced
this pull request
Feb 25, 2026
Replace remaining org.netlib.blas delegations in Java8BLAS with native Java implementations for symmetric, triangular, band matrix, and Level 1 operations. Add parameter validation to AbstractBLAS for dgbmv/sgbmv. Expand test suite across 41 test files with coverage for edge cases, non-unit strides, transpose variants, scaling factors, and drotmg/srotmg rescaling branches. Use relative tolerance for float tests where alpha amplifies values beyond absolute epsilon thresholds.
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Apr 22, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `dev.ludovic.netlib` to 3.2.0 for Apache Spark 4.2.0. ### Why are the changes needed? To bring the latest bug fixes and improvements from the upstream project. - https://github.com/luhenry/netlib/releases/tag/v3.2.0 - luhenry/netlib#35 - luhenry/netlib#39 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 Closes #55484 from dongjoon-hyun/SPARK-56576. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 14 remaining org.netlib.blas delegations in Java8BLAS with native Java implementations (symmetric, triangular, band matrix, and Level 1 operations). Add parameter validation to AbstractBLAS for dgbmv/sgbmv. Expand test suite across 40 test files with additional cases for edge values, non-unit strides, transpose variants, and drotmg/srotmg rescaling branches.