Improve BLAS test coverage and fix negative stride bug in Java8BLAS#36
Merged
Improve BLAS test coverage and fix negative stride bug in Java8BLAS#36
Conversation
Add extensive test coverage for Java8BLAS kernel methods, improving branch coverage from 81% to 89.4% and Java8BLAS specifically from 81% to 92.8%. Fix a bug in upper-triangular dspmvU/sspmvU/dsymvU/ssymvU where negative stride index initialization used (col-1) instead of (n-1), verified against the Fortran BLAS reference. Key changes: - Add negative stride tests for all Level 1 BLAS operations - Add negative stride tests for all Level 2 BLAS operations - Add small-dimension GEMM tests to exercise non-blocking kernel paths - Add TRSM/STRSM alpha scaling tests for R/N/U and R/N/L paths - Add dsymm/ssymm alpha=0 with beta!=0 tests for kernel beta branch - Fix 8 locations in Java8BLAS where upper-triangular spmv/symv used incorrect inner loop index for negative strides Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extensive test coverage for Java8BLAS kernel methods, improving branch coverage from 81% to 89.4% and Java8BLAS specifically from 81% to 92.8%. Fix a bug in upper-triangular dspmvU/sspmvU/dsymvU/ssymvU where negative stride index initialization used (col-1) instead of (n-1), verified against the Fortran BLAS reference.
Key changes: