Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Conversation

@darecki
Copy link
Contributor

@darecki darecki commented Mar 26, 2019

No description provided.

@darecki
Copy link
Contributor Author

darecki commented Mar 26, 2019

@luispadron could you enable Swift 5 on Travis? :)

@parrotbait
Copy link

Another vote on this one - it's blocking me due to the Swift 5 compile time error

@parrotbait
Copy link

Thanks @darecki for the PR!

@luispadron
Copy link
Owner

Thanks for the PR!

I think all you have to do is change the .travis.yml file to use osx_image: 10.2, however, that version of Xcode doesn't show up here so not sure if it supports Swift 5 yet? We can go ahead and make that change to the travis file and push and it should work if they support it.

@MihaelIsaev
Copy link

While we're waiting pod update a lib may be fixed manually like this

let a = max(ring.outerRingWidth, ring.innerRingWidth)
let b = ((valueKnobStyle?.size ?? 0) / 4)
let c = (borderWidth * 2)
let offSet = a / 2 + b + c

@haroldogtf
Copy link

Temporary workaround
pod 'UICircularProgressRing', :git => 'https://github.com/darecki/UICircularProgressRing.git', :branch => 'swift_5'

@darecki
Copy link
Contributor Author

darecki commented Mar 27, 2019

Thanks for the PR!

I think all you have to do is change the .travis.yml file to use osx_image: 10.2, however, that version of Xcode doesn't show up here so not sure if it supports Swift 5 yet? We can go ahead and make that change to the travis file and push and it should work if they support it.

I just found this: https://blog.travis-ci.com/2019-02-12-xcode-10-2-beta-2-is-now-available
I assume for now it should run on Xcode 10.2-beta and then switch to full version automatically. I'll update my PR

@yusuftor
Copy link

Can we merge this now?

@darecki
Copy link
Contributor Author

darecki commented Mar 27, 2019

@luispadron Do you think you can merge and release a new version?

@luispadron
Copy link
Owner

Sorry, been busy with school.

Thanks for the great work, I'll merge this and get a new pod and Carthage release out ASAP.

@luispadron luispadron merged commit ee3e4ea into luispadron:master Mar 27, 2019
@luispadron
Copy link
Owner

Available now in 6.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants