Skip to content

Conversation

@nathanael-ruf
Copy link
Contributor

ItemInstanceOpts typed some properties as ItemInstance<any>.
This PR passes the kind of item as a new generic parameter.
(disclaimer: I just tried it for my use case where it seems to work fine, but not sure if it has any other effects somewhere else. I guess you or CI will tell me.)

@lukasbach

(btw. I think we attended Lego Mindstorms and Computergrafik at KIT together, maybe you remember me 😄)

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: f253bce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Sep 26, 2025

View your CI Pipeline Execution ↗ for commit f253bce

Command Status Duration Result
cli run build:docs,build:sb --concurrency 1 ✅ Succeeded 45s View ↗
cli run build,build:cjs,build:esm --concurrency 1 ✅ Succeeded 35s View ↗
cli run test --stream ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-26 21:45:02 UTC

@lukasbach lukasbach merged commit 8cbef31 into lukasbach:main Sep 28, 2025
1 check passed
@lukasbach
Copy link
Owner

Hey Nathanael, ja ich erinnere mich, ist ja witzig 😄

Ich sehe du arbeitest aktuell bei Codesphere? Benutzt ihr Headless Tree auch dort? Grüße Alex von mir!

Und danke für den PR!

@gnarlex
Copy link

gnarlex commented Oct 7, 2025

Grüße zurück! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants