Add methods for easier serialization of nested classes in the LengthPrefixedBlock#16
Merged
lukaskabrt merged 5 commits intomasterfrom Jan 11, 2026
Merged
Add methods for easier serialization of nested classes in the LengthPrefixedBlock#16lukaskabrt merged 5 commits intomasterfrom
lukaskabrt merged 5 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds new API methods to simplify serialization of nested classes in Protocol Buffers by introducing a structured approach to writing length-prefixed blocks. The version is bumped from 0.3.0 to 0.4.0, indicating a minor release with new features.
Changes:
- Added three new public methods:
WriteRaw,StartLengthPrefixedBlock, andFinalizeLengthPrefixedBlockto support manual length-prefixed block serialization - Introduced a
LengthPrefixedBlockstruct to track block positions during serialization - Refactored
WriteScalarCollectionto use the new length-prefixed block methods
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/PbfLite/PbfLite.csproj | Version bump from 0.3.0 to 0.4.0 for the minor release |
| src/PbfLite/PbfBlockWriter.cs | Added WriteRaw, StartLengthPrefixedBlock, FinalizeLengthPrefixedBlock methods and LengthPrefixedBlock struct |
| src/PbfLite/PbfBlockWriter.Collections.cs | Refactored WriteScalarCollection to use new length-prefixed block methods |
| src/PbfLite.Tests/PbfBlockWriterTests.cs | Added test for length-prefixed block functionality with various estimated lengths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@lukaskabrt I've opened a new pull request, #17, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@lukaskabrt I've opened a new pull request, #18, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Make LengthPrefixedBlock fields readonly using primary constructor Co-authored-by: lukaskabrt <2894161+lukaskabrt@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lukaskabrt <2894161+lukaskabrt@users.noreply.github.com>
* Initial plan * Add dedicated tests for WriteRaw method Co-authored-by: lukaskabrt <2894161+lukaskabrt@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lukaskabrt <2894161+lukaskabrt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.