Later calls to sortable() mustn't overwrite options set in earlier calls
#470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @schuetzm this looks pretty good. I will need to check it and merge it soon. Thank you. 👍 Would be awesome if you have more PRs to help. |
lukasoppermann
added a commit
that referenced
this pull request
Nov 8, 2018
|
Merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
sortable()to enable sorting for newly added DOM elements, the options that were set by the first call are reverted to their defaults. This contradicts the documentation.This PR fixes the problem. I've also added a test case.
Note that I'm not sure about the relationship between
store(...).configand_data(..., 'opts'). AFAICS, the latter is only read from, so I assume the change in line 258 is safe.