Fix static padding calculation#235
Merged
Merged
Conversation
Owner
|
Thank you so much for spotting this! Merging. |
ulosc
pushed a commit
to ulosc/efficientnet
that referenced
this pull request
Aug 18, 2021
Fix static padding calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I was testing the models and found that the results were different between the EfficientNet model with static padding convolutions and the EfficientNet model with dynamic padding convolutions.
When I looked into the code I noticed that there was a difference in the padding's calculation.
The appropriate calculation is the one used for the dynamic padding ie:
[pad_w // 2, pad_w - pad_w // 2, pad_h // 2, pad_h - pad_h // 2](code)You can test it with the quick & dirty script I made: