Refactor WebPageController to use IPriceController and ComparisonResult#59
Refactor WebPageController to use IPriceController and ComparisonResult#59lukepring merged 4 commits intoSprint-2-Jackfrom
Conversation
Co-authored-by: lukepring <68820847+lukepring@users.noreply.github.com>
|
@copilot please review the conflict resolution i did to ensure code still runs as intended |
|
@lukepring The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
3 similar comments
|
@lukepring The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@lukepring The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@lukepring The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@lukepring The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@lukepring The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
Co-authored-by: lukepring <68820847+lukepring@users.noreply.github.com>
Reviewed and fixed the merge regression in commit |
WebPageControllerduplicated chart coordinate logic already handled byChartBuilder, and returned a loosely-typedMap<String, Object>instead of the existingComparisonResult/ChartDatadomain types — diverging from the REST API path.Changes
MarketDataServicewithIPriceController— the same interface used byPriceComparisonApiController, routing web requests throughPriceComparisonService→ChartBuilderlike the API doesChartBuilderMap<String, Object>result withComparisonResult— strongly-typed domain object added directly to the Thymeleaf model; template property access already matched the getters💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.