Skip to content

Cache-first strategy in AlphaVantageService to avoid redundant API calls #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepring merged 2 commits into from
Mar 20, 2026
Merged

Cache-first strategy in AlphaVantageService to avoid redundant API calls #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf480e
Initial plan
Copilot Mar 20, 2026
ae61434
Add cache-first check in AlphaVantageService.fetchSharePrices()
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions stockscope/src/main/java/com/sharecomparison/infrastructure/AlphaVantageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ public List<PriceData> fetchSharePrices(String symbol, LocalDate startDate, Loca
return repository.loadPrices(symbol, startDate, endDate);
}

List<PriceData> cached = repository.loadPrices(symbol, startDate, endDate);
if (!cached.isEmpty()) {
log.debug("Returning cached prices for symbol={} ({} to {})", symbol, startDate, endDate);
return cached;
}

String json = fetchTimeSeriesDailyJson(symbol, outputSize);
if (json == null) {
return repository.loadPrices(symbol, startDate, endDate);
Expand Down