Re-export embassy_time, upgrade dependencies (WIP)#32
Conversation
BartMassey
force-pushed
the
upgrade-20260103
branch
from
6b529f7 to
38640ce
Compare
|
Sigh. Bumped |
BartMassey
changed the title
|
Ok, fixed all the examples with the help of Claude (hope that's OK). Everything looks like it will compile now. Sadly, I needed to pin |
…ibility Removed explicit embassy-time dependencies from all examples in favor of using the re-exported version from microbit-bsp. This ensures consistent versioning across the codebase and reduces dependency duplication. Also updated nrf-sdc and nrf-mpsl to git versions compatible with embassy-nrf 0.9, and fixed the Rng API usage in ble.rs to match the updated embassy-nrf API. Fixed speaker example to use SimpleConfig parameter required by embassy-nrf 0.9. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
BartMassey
force-pushed
the
upgrade-20260103
branch
from
426480c to
41fc889
Compare
|
I would prefer to not re-export embassy-time, what's the error you're getting from the resolver? |
|
I couldn't find a version of Curious about the preference. It's hard to keep dependencies in sync if you don't do it this way, I think? Your call, obviously. I think it's worth updating versions either way: I (and the examples) can explicitly depend on |
|
I'm not sure what the best path forward is. You're right that since we're already exporting embassy-nrf, might as well export embassy-time too 🤔 Maybe the sweet spot here is to re-export embassy stuff at least. |
|
Absolutely happy to rewrite the patches however you want. Let me know what you decide. |
|
Need some version of this soon. What shall I do? Thanks. |
lulf
left a comment
lulf
left a comment
There was a problem hiding this comment.
This got lost, thanks for the ping. Let's try it like this.
2 participants
Re-exports the
embassy_timecrate to avoid resolver errors. Upgrades all dependencies and fix resulting breakage. Bumps the version to 0.5.0 because breaking changes.This PR depends on embassy-rs/embassy#5160 and should wait until that is upstreamed.