Fix the release action#114
Merged
Merged
Conversation
lukasoyen
approved these changes
Jun 12, 2025
Collaborator
|
@mkrakowiak-luminar Can we automate that? Having to manually bump the version in the pyproject.toml file is something that is easy to forget. Ideally we fix what we had before where the release action modifies the file and use this to create the release archive. |
Contributor
Author
|
Yes, we can. Feel free to create an issue for later, since we're investigated the possible implementations and that was too hard. BTW @hofbi look at the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous release mechanism was broken. It did replace the version in pyproject.toml, but the release archive was uploaded with the old contents.