Print number of excludes#122
Merged
Merged
Conversation
cbachhuber
reviewed
Jul 14, 2025
| total_excluded = sum(hook.count_excluded_files() for hook in hooks_list) | ||
| print(f"Total number of excluded files: {total_excluded}") | ||
|
|
||
| for hook in hooks_list: |
Contributor
There was a problem hiding this comment.
I think this is not necessarily sorted alphabetically by hook name, right? Shall we sort to get a stable output?
Collaborator
Author
There was a problem hiding this comment.
The order is based on the pre-commit config. To me this sounds like a valid approach and might be helpful to find the hooks in the config. The output is as stable as your config file.
Co-authored-by: Chris Bachhuber <cbachhuber89@gmail.com>
hofbi
commented
Jul 14, 2025
hofbi
commented
Jul 14, 2025
cbachhuber
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For metrics it is helpful to get an overview of how many files are actually excluded.
I am also adding a CI check to demonstrate how this works: https://github.com/luminartech/dev-tools/actions/runs/16270610957/job/45937021382?pr=122