Skip to content

Print number of excludes as json#123

Merged
cbachhuber merged 3 commits into
masterfrom
print-as-json
Jul 15, 2025
Merged

Print number of excludes as json#123
cbachhuber merged 3 commits into
masterfrom
print-as-json

Conversation

@hofbi
Copy link
Copy Markdown
Collaborator

@hofbi hofbi commented Jul 14, 2025

This makes it easier to use for metric collection

@hofbi hofbi requested review from cbachhuber and Copilot July 14, 2025 19:40
Copilot AI reviewed Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the exclusion count output to a JSON format for easier metric collection.

  • Replaced plain-text prints in print_excluded_files_count with a structured JSON payload.
  • Added an import json to enable serialization.

Comment thread dev_tools/check_useless_exclude_paths_hooks.py Outdated
Comment thread dev_tools/check_useless_exclude_paths_hooks.py Outdated
@cbachhuber cbachhuber merged commit 6d0cf6e into master Jul 15, 2025
8 checks passed
@cbachhuber cbachhuber deleted the print-as-json branch July 15, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@cbachhuber cbachhuber cbachhuber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hofbi @cbachhuber