Move pre-commit metrics into a separate hook#125
Merged
Conversation
This was referenced Jul 16, 2025
Merged
hofbi
added a commit
that referenced
this pull request
Jul 16, 2025
Once #125 is merged we can even do more e2e testing. The hooks currently skipped either don't make sense on this repo or don't work yet. I will create a follow up issue to track this. Co-authored-by: Chris Bachhuber <cbachhuber89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make this a separate hook for performance reasons. This should not run every time a developer commits, but only when explicitly calling the hook.
Also improve the CI job to eat our own dog food.