refactor(styles): Refactor styles for dark mode icon-shadow and SCSS variables#35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the SCSS styles to consistently use new theme variables for colors, shadows, and backgrounds, replacing hardcoded values and conditional logic. This improves maintainability, makes theme customization easier, and ensures visual consistency across light and dark modes.
Introduction of theme variables:
src/styles/_variables.scssfor accent colors, focus rings, drop borders, surface shadows, tray backgrounds, and tooltip colors, with specific overrides for light and dark variants. [1] [2]Refactoring to use variables:
src/styles/_overview.scssto replace hardcoded colors and shadows (e.g., selection backgrounds, drop highlights, dialog backgrounds, focus rings) with the new variables for accent and surface styling. [1] [2] [3] [4] [5]src/styles/_switcher.scssto use the new surface shadow and border variables instead of hardcoded values.src/styles/_tray-icons.scssto eliminate conditional SCSS blocks for light/dark variants, using the new tray and accent variables for hover, active, badge, and tooltip styles. [1] [2] [3] [4]Other improvements:
src/styles/_xwayland-indicator.scssto use the imported variables and apply the icon shadow only in dark mode, improving clarity and consistency.