Skip to content

Conversation

@slpsys
Copy link
Contributor

@slpsys slpsys commented Feb 25, 2017

@matl33t I think this was actually the issue. I was still seeing the unknown option issue after bumping to 3.0.2. Updating the GLI command seemed to work nicely. LMK if there are specs that cover this that I should also update.

marc$ broadside --debug bootstrap --target web --tag latest
error: Unknown option --tag

NAME
    bootstrap - Bootstrap your service and task definition from the configured definition.

SYNOPSIS
    broadside [global options] bootstrap [command options]

COMMAND OPTIONS
    -t, --target=TARGET - Deployment target to use, e.g. production_web (required, default: none)

@apurvis
Copy link
Contributor

apurvis commented Feb 26, 2017

hmm now i'm curious why that is the case... i'm going to scope this out on a deeper level

@apurvis
Copy link
Contributor

apurvis commented Feb 26, 2017

damn you are totally right. i'm going to try to add a spec to this branch so we don't f this up again and i'll merge it

@apurvis
Copy link
Contributor

apurvis commented Feb 26, 2017

@apurvis
Copy link
Contributor

apurvis commented Feb 26, 2017

funny because i just removed this in 3.0.1 because i thought having it was a bug =(

@apurvis
Copy link
Contributor

apurvis commented Feb 26, 2017

in the short term, i'm just going to merge and release this. we can figure out what the "right" answer is between the other two PRs later.

@apurvis apurvis merged commit a697d6f into master Feb 26, 2017
@apurvis apurvis deleted the add_tag_to_bootstrap branch February 26, 2017 20:02
@apurvis
Copy link
Contributor

apurvis commented Feb 26, 2017

re-released as 3.0.3


desc 'Bootstrap your service and task definition from the configured definition.'
command :bootstrap do |bootstrap|
add_tag_flag(run)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops this should have been add_tag_flag(bootstrap). fixing now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, my bad. I fixed this in my local copy (like, literally the copy of the installed gem), and forgot to change it in both places.

apurvis pushed a commit that referenced this pull request Feb 26, 2017
apurvis added a commit that referenced this pull request Feb 26, 2017
@apurvis
Copy link
Contributor

apurvis commented Feb 26, 2017

i went as far as yanking this release once 3.0.4 was published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants