-
Notifications
You must be signed in to change notification settings - Fork 8
Adding --tag to bootstrap command in GLI specification #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hmm now i'm curious why that is the case... i'm going to scope this out on a deeper level |
|
damn you are totally right. i'm going to try to add a spec to this branch so we don't f this up again and i'll merge it |
|
funny because i just removed this in 3.0.1 because i thought having it was a bug =( |
|
in the short term, i'm just going to merge and release this. we can figure out what the "right" answer is between the other two PRs later. |
|
re-released as 3.0.3 |
|
|
||
| desc 'Bootstrap your service and task definition from the configured definition.' | ||
| command :bootstrap do |bootstrap| | ||
| add_tag_flag(run) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops this should have been add_tag_flag(bootstrap). fixing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, my bad. I fixed this in my local copy (like, literally the copy of the installed gem), and forgot to change it in both places.
|
i went as far as |
@matl33t I think this was actually the issue. I was still seeing the unknown option issue after bumping to 3.0.2. Updating the GLI command seemed to work nicely. LMK if there are specs that cover this that I should also update.