Skip to content

ListDetails page frontend#103

Merged
jeroenrinzema merged 10 commits intomainfrom
fix/list-page
Jan 24, 2026
Merged

ListDetails page frontend#103
jeroenrinzema merged 10 commits intomainfrom
fix/list-page

Conversation

@JelgerDijkgraaf
Copy link
Copy Markdown
Contributor

@JelgerDijkgraaf JelgerDijkgraaf commented Dec 17, 2025

This PR fixes styling issues on the ListDetails page and transfers to the new nexus endpoints

@jeroenrinzema
Copy link
Copy Markdown
Contributor

@JelgerDijkgraaf we have new endpoints for data suggestions. You could use those instead.

@JelgerDijkgraaf JelgerDijkgraaf marked this pull request as ready for review January 12, 2026 13:07
@JelgerDijkgraaf JelgerDijkgraaf requested review from Copilot and removed request for jeroenrinzema January 12, 2026 13:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ListDetails page frontend by migrating to new nexus endpoints, fixing styling issues in the rule builder components, and adding pubsub integration to the backend for user identification events.

Changes:

  • Migrates frontend API calls from legacy endpoints to nexus endpoints for path suggestions
  • Refactors rule editor components to use new combobox UI component with improved styling
  • Adds pubsub publisher integration to users controller for event publishing
  • Updates TypeScript and React type definitions to newer versions

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
services/nexus/internal/http/controllers/v1/management/users.go Adds transaction handling and pubsub publishing to user identification
services/nexus/internal/http/controllers/v1/management/controller.go Updates controller initialization to include pubsub publisher
services/console/src/views/users/rules/WrapperRuleEdit.tsx Refactors component with improved conditional rendering and styling
services/console/src/views/users/rules/RuleHelpers.ts Adds optional chaining for safer property access
services/console/src/views/users/rules/RuleEventName.tsx Migrates from Headless UI to new Combobox component
services/console/src/views/users/rules/FilterRuleEdit.tsx Refactors to use new Combobox with updated logic
services/console/src/views/users/rules/EventRuleEdit.tsx Updates styling and formatting consistency
services/console/src/views/users/ListDetail.tsx Removes unused import
services/console/src/ui/form/TextInput.css Adjusts tiny input height for consistency
services/console/src/ui/form/SingleSelect.tsx Removes unused imports and adds gap styling
services/console/src/ui/form/Select.css Removes bottom margin and adds small variant height
services/console/src/components/ui/combobox.tsx Adds new Combobox component with filtering and custom rendering
services/console/src/api.ts Migrates path suggestions to nexus endpoints with response transformation
services/console/package.json Updates React and TypeScript to newer versions

Comment thread services/nexus/internal/http/controllers/v1/management/users.go
Comment thread services/console/src/views/users/rules/WrapperRuleEdit.tsx
Comment thread services/console/src/views/users/rules/FilterRuleEdit.tsx Outdated
Comment thread services/console/src/components/ui/combobox.tsx Outdated
@jeroenrinzema jeroenrinzema merged commit 0d803a3 into main Jan 24, 2026
4 checks passed
@jeroenrinzema jeroenrinzema deleted the fix/list-page branch January 24, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants