Merged
Conversation
Contributor
|
@JelgerDijkgraaf we have new endpoints for data suggestions. You could use those instead. |
There was a problem hiding this comment.
Pull request overview
This PR updates the ListDetails page frontend by migrating to new nexus endpoints, fixing styling issues in the rule builder components, and adding pubsub integration to the backend for user identification events.
Changes:
- Migrates frontend API calls from legacy endpoints to nexus endpoints for path suggestions
- Refactors rule editor components to use new combobox UI component with improved styling
- Adds pubsub publisher integration to users controller for event publishing
- Updates TypeScript and React type definitions to newer versions
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| services/nexus/internal/http/controllers/v1/management/users.go | Adds transaction handling and pubsub publishing to user identification |
| services/nexus/internal/http/controllers/v1/management/controller.go | Updates controller initialization to include pubsub publisher |
| services/console/src/views/users/rules/WrapperRuleEdit.tsx | Refactors component with improved conditional rendering and styling |
| services/console/src/views/users/rules/RuleHelpers.ts | Adds optional chaining for safer property access |
| services/console/src/views/users/rules/RuleEventName.tsx | Migrates from Headless UI to new Combobox component |
| services/console/src/views/users/rules/FilterRuleEdit.tsx | Refactors to use new Combobox with updated logic |
| services/console/src/views/users/rules/EventRuleEdit.tsx | Updates styling and formatting consistency |
| services/console/src/views/users/ListDetail.tsx | Removes unused import |
| services/console/src/ui/form/TextInput.css | Adjusts tiny input height for consistency |
| services/console/src/ui/form/SingleSelect.tsx | Removes unused imports and adds gap styling |
| services/console/src/ui/form/Select.css | Removes bottom margin and adds small variant height |
| services/console/src/components/ui/combobox.tsx | Adds new Combobox component with filtering and custom rendering |
| services/console/src/api.ts | Migrates path suggestions to nexus endpoints with response transformation |
| services/console/package.json | Updates React and TypeScript to newer versions |
jeroenrinzema
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes styling issues on the ListDetails page and transfers to the new nexus endpoints