Refactor: settings locales page refactored to shadcn components#127
Merged
jeroenrinzema merged 4 commits intomainfrom Feb 2, 2026
Merged
Refactor: settings locales page refactored to shadcn components#127jeroenrinzema merged 4 commits intomainfrom
jeroenrinzema merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the Settings → Locales page UI to use shadcn/ui components (Dialog, Table, Dropdown) and TanStack React Table.
Changes:
- Replaced the legacy
SearchTable+Modalimplementation with a shadcn-based table and dialog flow. - Introduced TanStack React Table for table rendering and state.
- Added
@tanstack/react-tabledependency and updated lockfile.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| services/console/src/views/settings/Locales.tsx | Refactors locales listing + create/delete UI to shadcn components and TanStack table state. |
| services/console/package.json | Adds @tanstack/react-table dependency. |
| pnpm-lock.yaml | Lockfile updates for the new dependency (and associated snapshots). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
jeroenrinzema
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.