Feat/issue 192#210
Merged
jeroenrinzema merged 7 commits intomainfrom Apr 11, 2026
Merged
Conversation
RickieeeDev
force-pushed
the
feat/issue-192
branch
from
e63613e to
866f51d
Compare
There was a problem hiding this comment.
Pull request overview
Adds an unsubscribe status lookup in the management subscriptions store and uses it in the campaigns send consumer to skip non-transactional sends for users who have unsubscribed from the campaign’s subscription.
Changes:
- Add
IsUserUnsubscribedtoSubscriptionsStore(withsql.ErrNoRowshandling). - Update campaign send consumer to skip sending when the user is unsubscribed (non-transactional campaigns only).
- Add store-level tests covering
IsUserUnsubscribedbehavior across no-record/unsubscribe/resubscribe cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/store/management/subscriptions.go | Adds IsUserUnsubscribed query helper for user+subscription unsubscribe state. |
| internal/store/management/subscriptions_test.go | Adds unit test coverage for IsUserUnsubscribed across key state transitions. |
| internal/pubsub/consumer/campaigns.go | Skips non-transactional campaign sends when the user is unsubscribed from the campaign’s subscription. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@RickieeeDev could you please take a look at the failing lint and tests? |
Switch user_subscription.state from integer to VARCHAR with a check constraint. Update code to use 'unsubscribed' string instead of integer constant. Simplify IsUserUnsubscribed logic.
jeroenrinzema
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.