Set default name, from, reply-to address#40
Merged
jeroenrinzema merged 1 commit intomainfrom Oct 13, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ability to set default name, from, and reply-to addresses for email providers, allowing these values to be used as fallbacks when templates don't specify them explicitly.
- Added default email fields (default_from, default_from_name, default_reply_to) to email provider schemas
- Modified template mapping to be asynchronous and incorporate provider defaults when rendering email templates
- Updated UI components to display and use provider defaults with proper fallback behavior
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/platform/src/render/TemplateService.ts | Added provider import and made template mapping async |
| services/platform/src/render/TemplateController.ts | Updated template mapping calls to be async |
| services/platform/src/render/Template.ts | Made map() async and added withProvider() method for email templates |
| services/platform/src/providers/email/*.ts | Updated email provider schemas to use EmailProviderSchema |
| services/platform/src/providers/email/EmailProvider.ts | Added EmailProviderSchema with default email field support |
| services/platform/src/providers/MessageTriggerService.ts | Updated template mapping calls to be async |
| services/platform/src/campaigns/CampaignService.ts | Added getCampaignProvider function and updated template mapping |
| services/console/src/views/settings/IntegrationModal.tsx | Minor import ordering fix |
| services/console/src/views/campaign/template/TemplateDetail.tsx | Added provider context to email template components |
| services/console/src/views/campaign/template/EmailTemplate.tsx | Enhanced UI to show provider defaults and use them as fallbacks |
| services/console/src/ui/Tag.tsx | Minor import ordering fix |
| services/console/src/ui/InfoTable.css | Removed trailing whitespace |
| services/console/public/locales/en.json | Added translation key |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9519812 to
bcbf44b
Compare
bcbf44b to
6c467ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the ability to set a default name, from, and reply-to address, closes #39.