Skip to content

Set default name, from, reply-to address#40

Merged
jeroenrinzema merged 1 commit intomainfrom
feat/default-email-properties
Oct 13, 2025
Merged

Set default name, from, reply-to address#40
jeroenrinzema merged 1 commit intomainfrom
feat/default-email-properties

Conversation

@jeroenrinzema
Copy link
Copy Markdown
Contributor

Include the ability to set a default name, from, and reply-to address, closes #39.

image

@jeroenrinzema jeroenrinzema requested a review from Copilot October 13, 2025 21:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the ability to set default name, from, and reply-to addresses for email providers, allowing these values to be used as fallbacks when templates don't specify them explicitly.

  • Added default email fields (default_from, default_from_name, default_reply_to) to email provider schemas
  • Modified template mapping to be asynchronous and incorporate provider defaults when rendering email templates
  • Updated UI components to display and use provider defaults with proper fallback behavior

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/platform/src/render/TemplateService.ts Added provider import and made template mapping async
services/platform/src/render/TemplateController.ts Updated template mapping calls to be async
services/platform/src/render/Template.ts Made map() async and added withProvider() method for email templates
services/platform/src/providers/email/*.ts Updated email provider schemas to use EmailProviderSchema
services/platform/src/providers/email/EmailProvider.ts Added EmailProviderSchema with default email field support
services/platform/src/providers/MessageTriggerService.ts Updated template mapping calls to be async
services/platform/src/campaigns/CampaignService.ts Added getCampaignProvider function and updated template mapping
services/console/src/views/settings/IntegrationModal.tsx Minor import ordering fix
services/console/src/views/campaign/template/TemplateDetail.tsx Added provider context to email template components
services/console/src/views/campaign/template/EmailTemplate.tsx Enhanced UI to show provider defaults and use them as fallbacks
services/console/src/ui/Tag.tsx Minor import ordering fix
services/console/src/ui/InfoTable.css Removed trailing whitespace
services/console/public/locales/en.json Added translation key

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread services/platform/src/campaigns/CampaignService.ts Outdated
Comment thread services/platform/src/render/Template.ts Outdated
@jeroenrinzema jeroenrinzema force-pushed the feat/default-email-properties branch from 9519812 to bcbf44b Compare October 13, 2025 21:43
@jeroenrinzema jeroenrinzema force-pushed the feat/default-email-properties branch from bcbf44b to 6c467ba Compare October 13, 2025 21:44
@jeroenrinzema jeroenrinzema merged commit 9373356 into main Oct 13, 2025
2 checks passed
@jeroenrinzema jeroenrinzema deleted the feat/default-email-properties branch October 13, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default from and name

2 participants