Migrated delete, duplicate, and retrieve campaign users to nexus service#65
Merged
jeroenrinzema merged 3 commits intomainfrom Nov 29, 2025
Merged
Migrated delete, duplicate, and retrieve campaign users to nexus service#65jeroenrinzema merged 3 commits intomainfrom
jeroenrinzema merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates three campaign-related endpoints (delete, duplicate, and retrieve campaign users) from a legacy service to the Nexus service, completing the campaign API migration to the new architecture.
Key changes:
- Added OpenAPI specifications for delete, duplicate, and get campaign users endpoints
- Implemented corresponding database operations and HTTP handlers
- Created comprehensive test coverage for all new endpoints
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/nexus/oapi/resources.yml | Defines OpenAPI specs for delete campaign, duplicate campaign, and get campaign users endpoints |
| services/nexus/oapi/resources_gen.go | Auto-generated client/server code from OpenAPI specs including models, request builders, and routing |
| services/nexus/internal/store/campaigns.go | Implements database operations for deleting campaigns, retrieving campaign users, and related data models |
| services/nexus/internal/store/templates.go | Adds template duplication logic for copying templates to new campaigns |
| services/nexus/internal/http/controllers/v1/campaigns.go | Implements HTTP handlers for delete, duplicate, and get campaign users operations |
| services/nexus/internal/http/controllers/v1/campaigns_test.go | Adds comprehensive tests for the new campaign endpoints |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@jeroenrinzema I've opened a new pull request, #66, to work on those changes. Once the pull request is ready, I'll request review from you. |
#66) * Initial plan * Fix naming inconsistency: rename send_at to sent_at in campaign_sends table Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the remaining campaign endpoints.