Fix GetLocale test to match OpenAPI specification#87
Merged
jeroenrinzema merged 3 commits intomainfrom Dec 1, 2025
Merged
Conversation
Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing locale tests
Fix GetLocale response format to match API convention
Dec 1, 2025
jeroenrinzema
requested changes
Dec 1, 2025
Comment on lines
+159
to
+161
| json.Write(w, http.StatusOK, map[string]interface{}{ | ||
| "data": locale.OAPI(), | ||
| }) |
Contributor
There was a problem hiding this comment.
the locale OAPI should not be returned in a data object. Please update the OpenAPI specs if needed.
Contributor
Author
There was a problem hiding this comment.
Fixed in 06c7f04. Reverted the controller to return the locale directly (matching the OpenAPI spec) and updated the test to expect the Locale object without the "data" wrapper.
Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com>
Copilot
AI
changed the title
Fix GetLocale response format to match API convention
Fix GetLocale test to match OpenAPI specification
Dec 1, 2025
jeroenrinzema
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetLocaletest was incorrectly expecting the response to be wrapped in a"data"field, causing test failures:Changes
Localeobject directly instead of wrapped in a"data"fieldThe OpenAPI specification at
services/nexus/oapi/resources.ymldefines theGetLocaleendpoint response as:This clearly indicates the response should be a
Localeobject directly, not wrapped in a data field. The test has been updated to align with this specification.Testing
✅ All locale tests passing (TestGetLocale/get_by_id, TestGetLocale/get_by_key, TestGetLocale/not_found)
✅ Code compiles successfully
✅ CodeQL security check passed
Fixes Locale tests are failing #86
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.