Skip to content

implemente bulk update/import users to list#95

Merged
jeroenrinzema merged 4 commits intomainfrom
feat/lists-improvements
Dec 2, 2025
Merged

implemente bulk update/import users to list#95
jeroenrinzema merged 4 commits intomainfrom
feat/lists-improvements

Conversation

@jeroenrinzema
Copy link
Copy Markdown
Contributor

No description provided.

@jeroenrinzema jeroenrinzema marked this pull request as ready for review December 1, 2025 22:27
@jeroenrinzema jeroenrinzema requested a review from Copilot December 1, 2025 22:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements bulk user import functionality for static lists via CSV upload. The implementation includes CSV parsing with flexible column ordering, user upsert operations, and list membership management.

Key changes:

  • Refactored UpsertUser to use a structured params object instead of individual parameters
  • Changed users_count from optional to required field in the List schema
  • Added CSV import endpoint for bulk adding users to lists

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
services/nexus/oapi/resources.yml Made users_count a required field in List schema
services/nexus/oapi/resources_gen.go Updated generated code to reflect required users_count field
services/nexus/internal/store/users.go Refactored UpsertUser to accept structured UpsertUserParams
services/nexus/internal/store/users_test.go Updated tests to use new UpsertUserParams structure
services/nexus/internal/store/lists.go Added typed constants for list types/states and AddUserToList method
services/nexus/internal/importer/users.go New CSV mapper for transforming CSV rows to user upsert parameters
services/nexus/internal/http/controllers/v1/users.go Updated to use UpsertUserParams structure
services/nexus/internal/http/controllers/v1/lists.go Added ImportListUsers endpoint with CSV processing
services/nexus/internal/http/controllers/v1/lists_test.go Added comprehensive tests for CSV import functionality
services/nexus/internal/http/controllers/v1/controller.go Wired up max upload size configuration for lists controller
services/nexus/internal/http/controllers/v1/test/users/*.csv Test fixtures for CSV import scenarios
services/console/public/templates/users.csv Updated template to match supported import fields

Comment thread services/nexus/internal/importer/users.go
Comment thread services/nexus/internal/http/controllers/v1/lists.go Outdated
Comment thread services/nexus/internal/http/controllers/v1/lists_test.go Outdated
Comment thread services/nexus/internal/http/controllers/v1/lists_test.go Outdated
Comment thread services/nexus/internal/http/controllers/v1/lists.go
@jeroenrinzema jeroenrinzema merged commit 37d6362 into main Dec 2, 2025
3 checks passed
@jeroenrinzema jeroenrinzema deleted the feat/lists-improvements branch December 2, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants