Allow controller tests to be executed in parallel#98
Merged
jeroenrinzema merged 5 commits intomainfrom Dec 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables parallel execution of controller tests in the Nexus service by adding t.Parallel() to all test functions and increasing the PostgreSQL max_connections limit to accommodate concurrent database access.
- Adds
t.Parallel()to all controller test functions across multiple test files - Increases PostgreSQL container max_connections from default 100 to 500 to support parallel test execution
- Adds explanatory comments about the max_connections increase
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| services/nexus/internal/http/controllers/v1/users_test.go | Added parallel execution for 14 user controller tests |
| services/nexus/internal/http/controllers/v1/templates_test.go | Added parallel execution for 4 template controller tests |
| services/nexus/internal/http/controllers/v1/tags_test.go | Added parallel execution for 5 tag controller tests |
| services/nexus/internal/http/controllers/v1/projects_test.go | Added parallel execution for 4 project controller tests |
| services/nexus/internal/http/controllers/v1/organizations_test.go | Added parallel execution for 4 organization controller tests |
| services/nexus/internal/http/controllers/v1/locales_test.go | Added parallel execution for 5 locale controller tests |
| services/nexus/internal/http/controllers/v1/lists_test.go | Added parallel execution for 7 list controller tests |
| services/nexus/internal/http/controllers/v1/journeys_test.go | Added parallel execution for 5 journey controller tests |
| services/nexus/internal/http/controllers/v1/documents_test.go | Added parallel execution for 5 document controller tests |
| services/nexus/internal/http/controllers/v1/campaigns_test.go | Added parallel execution for 7 campaign controller tests |
| services/nexus/internal/http/controllers/v1/admins_test.go | Added parallel execution for 7 admin controller tests |
| pkg/container/postgres.go | Increased max_connections to 500 with explanatory comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.