Scroll sync #15
Scroll sync #15
Conversation
This reverts commit b229d4b.
|
Any idea? @dark-flames |
src/components/DefaultConfig.js
Outdated
| KatexParser, | ||
| HighlightjsParser | ||
| HighlightjsParser, | ||
| InjectLnParser |
There was a problem hiding this comment.
InjectLnParser Should be import at MarkdownPalettes.vue
There was a problem hiding this comment.
Why? We also import HighlightjsParser and KatexParser in this file.
There was a problem hiding this comment.
Because Content Parser not only be used in editor, it can also be export as a function.
There was a problem hiding this comment.
But defaultConfig is just the config of the editor, right? e.g. defaultConfig.fullScreen. I don't think it will be used in other places.
There was a problem hiding this comment.
But I think get default config from defaultConfig is more properly.
There was a problem hiding this comment.
Generally, ContentParser and Editor use same rendering config.But InjectLnParser only used in editor
There was a problem hiding this comment.
Of course, getDefaultContentParser in src\module need update.
| return this.$parent[name] | ||
| }, | ||
| set(val) { | ||
| this.$parent[name] = val |
There was a problem hiding this comment.
Emit an event and handle it in parent component is better.
src/components/PreviewArea.vue
Outdated
| ...computeFromParent('cursorLine'), | ||
| ...computeFromParent('cursorOffset'), | ||
| ...computeFromParent('scrolled'), | ||
| ...computeFromParent('clickLine'), |
There was a problem hiding this comment.
Use props with watch is better.
|
I am rewriting and improving scroll sync. Please don't merge at present. |
|
Finished! 🎉 |
ghost
changed the title
|
🎉 |
1 participant
Support scroll sync.
When cursor moves, the preview scrolls automatically.
When clicking preview, the editor scrolls automatically.
Note that it's very naive and leak of user experience design. I just provide a way to implement it and you need to optimize it.