Skip to content

Revert "added regex prior to profiles calculation" #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Revert "added regex prior to profiles calculation" #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions similarity/cosine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@
from .string_distance import NormalizedStringDistance
from .string_similarity import NormalizedStringSimilarity

import re
_SPACE_PATTERN = re.compile("\\s+")


class Cosine(ShingleBased, NormalizedStringDistance,
NormalizedStringSimilarity):
Expand All @@ -44,10 +41,6 @@ def similarity(self, s0, s1):
raise TypeError("Argument s1 is NoneType.")
if s0 == s1:
return 1.0

s0 = _SPACE_PATTERN.sub("", s0)
s1 = _SPACE_PATTERN.sub("", s1)

if len(s0) < self.get_k() or len(s1) < self.get_k():
return 0.0
profile0 = self.get_profile(s0)
Expand Down
6 changes: 0 additions & 6 deletions similarity/jaccard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
from .string_distance import NormalizedStringDistance, MetricStringDistance
from .string_similarity import NormalizedStringSimilarity

import re
_SPACE_PATTERN = re.compile("\\s+")

class Jaccard(ShingleBased, MetricStringDistance, NormalizedStringDistance, NormalizedStringSimilarity):

Expand All @@ -40,10 +38,6 @@ def similarity(self, s0, s1):
raise TypeError("Argument s1 is NoneType.")
if s0 == s1:
return 1.0

s0 = _SPACE_PATTERN.sub("", s0)
s1 = _SPACE_PATTERN.sub("", s1)

if len(s0) < self.get_k() or len(s1) < self.get_k():
return 0.0
profile0 = self.get_profile(s0)
Expand Down