Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for storing and retrieving values of any type (not just strings) in the cache, refactors the client and server code to handle generic types, and adds new documentation and configuration examples for deployment, architecture, monitoring, and Raft integration. Additionally, it improves metrics reporting for cache memory usage and enhances the startup configuration and health endpoints. Below are the most important changes grouped by theme.
Core cache and API changes:
stringtoanyinpkg/cache/cache.go, and updated all relevant cache methods (Set,Get,handleExpiredKey) to support generic values. [1] [2] [3] [4]Anyfor value serialization/deserialization, enabling support for arbitrary types. This includes changes topkg/client/client.goand the OpenAPI/Swagger spec. [1] [2] [3] [4]Configuration and startup improvements:
config.example.yaml) and refactored startup logic inpkg/cmd/main.goto load configuration, support hot reload, and configure Raft for distributed mode. Health and readiness endpoints were also added. [1] [2] [3] [4] [5] [6]Metrics and monitoring enhancements:
pkg/cache/metrics.go. [1] [2] [3]docs/monitoring.md.Documentation updates:
docs/architecture.md), deployment (docs/deployment.md), Raft integration (docs/raft.md), and code quality report (docs/quality_report.md). [1] [2] [3] [4]Testing and benchmarking:
bench/benchmark_test.goto measureSetandGetperformance.