Skip to content

docs(user): refresh user-facing docs (post-session-2026-04-29)#216

Merged
lusoris merged 1 commit intomasterfrom
docs/refresh-user-facing
May 1, 2026
Merged

docs(user): refresh user-facing docs (post-session-2026-04-29)#216
lusoris merged 1 commit intomasterfrom
docs/refresh-user-facing

Conversation

@lusoris
Copy link
Copy Markdown
Owner

@lusoris lusoris commented Apr 29, 2026

Summary

Refresh user-facing docs to match current codebase state.

  • docs/metrics/features.md — de-duplicate the extractor overview table (3 leftover dupe rows removed); reflect CAMBI Vulkan (T7-36 / ADR-0210), integer-SSIM Vulkan (T7-24), SSIMULACRA 2 CUDA/SYCL twins (ADR-0206), and the in-flight PSNR Vulkan chroma path (T3-15(b) / PR feat(vulkan): T3-15(b) — psnr chroma (psnr_cb / psnr_cr) on Vulkan #204) via footnotes; rewrite the per-section Backends lines for CAMBI, SSIM, and PSNR to match.
  • docs/api/gpu.md — flip the Vulkan section from "scaffold only as of v3.0" to "T5-1c full default-model coverage". List the live extractors, point at T7-29 image-import zero-copy API (vmaf_vulkan_state_init_external + import_image), and at the T7-10 HIP scaffold (PR feat(hip): T7-10 — HIP (AMD) backend scaffold (audit-first) #200, future libvmaf_hip.h).
  • CHANGELOG.md — Unreleased § Changed entry.

Doc-only refresh; no code changes. Sister agents own README/top-level + planning files; this PR scoped strictly to docs/usage/, docs/metrics/, docs/backends/, docs/ai/, docs/mcp/, docs/api/ per the parent task.

Deep-dive deliverables (ADR-0108)

  • no research digest needed: doc-only refresh; cites recently merged PRs.
  • no alternatives: only-one-way doc refresh.
  • no rebase-sensitive AGENTS invariants in this PR.
  • Reproducer / smoke-test command — see Test plan (markdownlint pass).
  • CHANGELOG.md entry — Unreleased § Changed.
  • no rebase note needed: doc-only.

Test plan

  • `npx markdownlint-cli2 docs/metrics/features.md docs/api/gpu.md` — `Summary: 0 error(s)`.
  • `git diff --stat` shows 3 files changed, +102 / -48; no code touched.
  • CHANGELOG.md was lint-equivalent before/after (28 pre-existing errors, no new ones added by this PR).
  • No Netflix golden assertions touched (`python/test/` untouched).

Hard constraints

  • Netflix golden assertions untouched (CLAUDE.md §8).
  • Touched docs lint-clean per markdownlint-cli2 against `.markdownlint.json`.
  • No code, no public-header, no CLI-flag changes — strictly doc.

🤖 Generated with Claude Code

Refresh docs that drifted from recent merged surfaces:

- docs/metrics/features.md — de-duplicate the extractor overview
  table (3 dupe rows from past merge conflicts removed); reflect
  CAMBI Vulkan (T7-36 / ADR-0210), integer-SSIM Vulkan (T7-24),
  SSIMULACRA 2 CUDA / SYCL twins (ADR-0206), and the in-flight
  PSNR Vulkan chroma path (T3-15(b) / PR #204) via footnotes;
  rewrite the per-section Backends lines for CAMBI, SSIM, and
  PSNR to match.
- docs/api/gpu.md — flip the Vulkan section from "scaffold only
  as of v3.0" to "T5-1c full default-model coverage". List the
  live extractors, point at T7-29 image-import zero-copy API
  (vmaf_vulkan_state_init_external + import_image), and at the
  T7-10 HIP scaffold (PR #200, libvmaf_hip.h follow-up).
- CHANGELOG.md — Unreleased § Changed entry for the doc-only
  refresh.

Doc-only — no code changes.
Copilot AI review requested due to automatic review settings May 1, 2026 17:03
@lusoris lusoris force-pushed the docs/refresh-user-facing branch from 70b036e to a4dd91a Compare May 1, 2026 17:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates user-facing documentation to reflect the current GPU-backend and extractor landscape, aligning docs with recently landed Vulkan/HIP work and feature-matrix cleanups.

Changes:

  • Cleans up and updates the extractor/feature matrix in docs/metrics/features.md (dedupe + backend/footnote updates).
  • Refreshes docs/api/gpu.md Vulkan status/coverage and related GPU API notes.
  • Adds an Unreleased changelog entry describing the doc refresh.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File Description
docs/metrics/features.md Updates the feature/extractor overview table and multiple backend-description sections (PSNR/SSIM/CAMBI/LPIPS notes).
docs/api/gpu.md Updates the GPU API documentation, especially Vulkan status and related lifecycle/limitations notes.
CHANGELOG.md Adds an Unreleased “Changed” entry documenting the doc refresh.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/api/gpu.md
Comment on lines +192 to +194
- No HIP path in this header. The HIP / AMD-ROCm backend is being
scaffolded under T7-10 (PR #200, in flight) — a future
`libvmaf_hip.h` will mirror this surface. See
Comment thread docs/api/gpu.md
Comment on lines +381 to +383
> `float_vif_vulkan`, `float_motion_vulkan`, `psnr_vulkan` (luma;
> chroma via T3-15(b) PR #204), `psnr_hvs_vulkan`, `ciede_vulkan`,
> `float_ssim_vulkan`, `float_ms_ssim_vulkan`, `float_ansnr_vulkan`,
Comment thread docs/api/gpu.md
Comment on lines +387 to +388
> (`vmaf_vulkan_state_init_external` / `_import_image` /
> `_wait_compute` / `_read_imported_pictures`) landed via T7-29 /
Comment thread docs/api/gpu.md
Comment on lines +463 to +464
- HIP / AMD-ROCm support is scaffolded under T7-10 (PR #200);
a public `libvmaf_hip.h` is planned to mirror this surface.
Comment thread docs/metrics/features.md
Comment on lines +58 to +62
(`psnr_y`). `psnr_vulkan` adds `psnr_cb` / `psnr_cr` chroma metrics
when `enable_chroma=true` (default) — see T3-15(b) work-in-progress
PR #204 / [`backends/vulkan/overview.md`](../backends/vulkan/overview.md).
The CPU `psnr` extractor emits the full luma + chroma set on every
build. CUDA / SYCL chroma support is a focused follow-up.
Comment thread docs/metrics/features.md
| PSNR (float) | `float_psnr` | No | `float_psnr` (luma only — the CPU extractor emits a single luma score) | AVX2, AVX-512, NEON | CUDA, SYCL, Vulkan |
| PSNR-HVS | `psnr_hvs` | No | `psnr_hvs`, `psnr_hvs_y`, `psnr_hvs_cb`, `psnr_hvs_cr` | AVX2, NEON | CUDA, SYCL, Vulkan |
| SSIM (fixed) | `ssim` | No | `ssim` | — | |
| SSIM (fixed) | `ssim` | No | `ssim` | — | Vulkan² |
Comment thread docs/metrics/features.md
Comment on lines +64 to +66
² SSIM (fixed-point) ships a Vulkan kernel via T7-24 (ADR-pending);
the CPU integer path is scalar-only by design. The `float_ssim` /
`float_ms_ssim` paths cover all three GPU backends.
Comment thread docs/metrics/features.md
Comment on lines +418 to +420
(`psnr_y`); `psnr_vulkan` is gaining `psnr_cb` / `psnr_cr` chroma
support via T3-15(b) (PR #204, in flight). `float_psnr` adds
CUDA / SYCL / Vulkan twins on the float pipeline.
@lusoris lusoris merged commit a3f3e4f into master May 1, 2026
57 checks passed
@lusoris lusoris deleted the docs/refresh-user-facing branch May 1, 2026 17:19
@github-actions github-actions Bot mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants