ci(aggregator): extend poll deadline 8m → 30m (post-bootstrap fix)#413
Merged
ci(aggregator): extend poll deadline 8m → 30m (post-bootstrap fix)#413
Conversation
First post-#410 run on PR #400 hit the 8-minute poll deadline while the Ubuntu gcc/clang DNN + Windows MSVC builds were still IN_PROGRESS and were declared FAILURE by the aggregator (their actual conclusion would have been success a few minutes later). The fork's slowest required builds take 12+ minutes; 30-minute poll deadline gives ~2x headroom. Job-level timeout-minutes raised to 35 so the GitHub-side kill doesn't pre-empt the poll. No semantic change to the aggregator logic; same accept-set (success/skipped/neutral, plus "never appeared" = path-filter rejection). Single-line numeric tweak.
There was a problem hiding this comment.
Pull request overview
Adjusts the Required Checks Aggregator workflow’s timing parameters so it doesn’t prematurely fail while slow required builds are still running, aligning the aggregator’s polling window with the repo’s real-world CI runtimes.
Changes:
- Increased the aggregator job
timeout-minutesfrom 15 → 35. - Increased the in-script polling deadline from 8 minutes → 30 minutes and expanded the explanatory comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+75
to
+78
| // applicable (acceptable). A run still IN_PROGRESS at deadline | ||
| // is treated as failure — extend `deadline` if your matrix is | ||
| // slower. The Ubuntu gcc/clang DNN + Windows MSVC builds can | ||
| // take 12+ minutes each; 30 minutes covers them with headroom. |
Comment on lines
+72
to
+78
| // Poll up to 30 minutes for sibling workflows to register their | ||
| // check_runs and reach a terminal state. A run that has never | ||
| // appeared after the timeout is treated as path-filter-not- | ||
| // applicable (acceptable). A run still IN_PROGRESS at deadline | ||
| // is treated as failure — extend `deadline` if your matrix is | ||
| // slower. The Ubuntu gcc/clang DNN + Windows MSVC builds can | ||
| // take 12+ minutes each; 30 minutes covers them with headroom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First post-#410 run on PR #400 hit the 8-minute poll deadline while the Ubuntu gcc/clang DNN + Windows MSVC builds were still IN_PROGRESS, and the aggregator declared them FAILURE. They would have completed successfully a few minutes later.
The fork's slowest required builds take 12+ minutes; 30-minute poll deadline gives ~2× headroom. Job-level
timeout-minutesraised 15 → 35 so the GitHub-side kill doesn't pre-empt the poll.No semantic change to the aggregator logic; same accept-set (success/skipped/neutral, plus "never appeared" = path-filter rejection). Single-file numeric tweak.
Six deep-dive deliverables
no digest needed: trivial timeout-tuning fix; no architectural decisionno alternatives: only-one-way fix — make the deadline match real build timesno rebase-sensitive invariants: single workflow file changepython3 -c "import yaml; yaml.safe_load(open('.github/workflows/required-aggregator.yml'))"— cleanno changelog needed: fixes a CI policy file's tunable that landed in the same release window via #410; user-visible behaviour unchangedno rebase impact: workflow-only change to fork-local CITest plan
🤖 Generated with Claude Code