fix(gitleaks): allowlist manifests/README.md false positive#59
Merged
fix(gitleaks): allowlist manifests/README.md false positive#59
Conversation
The `generic-api-key` rule flags ` - key: src01_hrc00_576x324` in ai/src/vmaf_train/data/manifests/README.md line 20 because "key:" + an entropic token (a public Netflix VMAF sample name) matches its heuristic. That README is documentation showing the YAML manifest format, not a manifest itself — no real secrets live there. Only surfaced now because PR #58's ours-merge expanded the gitleaks scan range (`--first-parent 966be8d^..<merge>`) to every fork commit since divergence. Prior PR-diff-only scans never touched this file. Add an explicit path allowlist entry (not a regex/stopword) so future edits to real manifest files still get scanned. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitleaks.tomlallowlist:^ai/src/vmaf_train/data/manifests/README\.md$generic-api-keyfalse positive where the rule flagged a YAML example (- key: src01_hrc00_576x324) as a secretWhy now
Surfaced by PR #58's ours-merge, which expanded the gitleaks scan range (
--first-parent 966be8d5^..<merge>) to every fork commit since divergence. Regular PR-diff-only scans missed it because the file was unchanged in those PRs.Test plan
.mdinai/src/vmaf_train/data/manifests/exists yet that would be accidentally masked🤖 Generated with Claude Code