Skip to content

Add copy name button to side bar#1436

Closed
acmore wants to merge 2 commits intolutzroeder:mainfrom
acmore:main
Closed

Add copy name button to side bar#1436
acmore wants to merge 2 commits intolutzroeder:mainfrom
acmore:main

Conversation

@acmore
Copy link

@acmore acmore commented Mar 3, 2025

This PR is to add a copy action to the names of the node and arguments.

@lutzroeder
Copy link
Owner

@acmore adding another button to most text fields adds quite a bit of clutter to the user interface while the same can be accomplished via select and copy. How could this be solved differently? Have you explored alternatives?

@acmore
Copy link
Author

acmore commented Mar 9, 2025

@acmore adding another button to most text fields adds quite a bit of clutter to the user interface while the same can be accomplished via select and copy. How could this be solved differently? Have you explored alternatives?

Yeah, select and copy can work by select the text carefully when the name is longer. But there are some issues:

  1. When the name is longer, it's a bit difficult to select
  2. The text selected in this way included a new line
  3. Sometimes will click through the element when it's a tensor

I do agree that it's a bit redundant, I am good to keep it in my own branch :)

@acmore acmore closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants