env: drop LUX_ prefix from env vars (noise)#38
Merged
Conversation
Renames LUX_-prefixed env vars to canonical, non-noisy forms: - LUX_MNEMONIC -> MNEMONIC (deploy script + LLM doc) - LUX_PRIVATE_KEY -> PRIVATE_KEY (deploy script + LLM doc) - LUX_INSECURE_TLS -> INSECURE_TLS - LUX_NODE_ENDPOINT -> NODE_ENDPOINT - LUX_NETWORK_TYPE -> NETWORK_TYPE (backend gRPC server selector) - LUX_RPC_URL -> RPC_URL - LUX_NODE_ROOT -> NODE_ROOT - LUX_CHART_PATH -> CHART_PATH - LUX_CHAINS_FILE -> CHAINS_FILE - LUX_KMS_ROOT_KEY -> KMS_ROOT_KEY - LUX_WC_PROJECT_ID -> WC_PROJECT_ID (WalletConnect) - LUX_BLS_KEY -> BLS_KEY (was already supported via getEnv()) - LUX_KEY_INDEX -> KEY_INDEX (was already supported via getEnv()) pkg/key/backend_env.go: removed the LUX_-prefix-stripping getEnv() helper (now reads env vars by exact name) and dropped the broken "MNEMONIC / MNEMONIC" / "PRIVATE_KEY / PRIVATE_KEY" doc comments which were a previous incomplete rename. NOT renamed (defined in upstream luxfi/constants — separate concern): - LUX_NODE_PATH (constants.EnvNodePath) - LUX_NETRUNNER_PATH (constants.EnvNetrunnerPath) - LUX_EVM_PATH (constants.EnvEVMPath) - LUX_PLUGINS_DIR (constants.EnvPluginsDir) Doc comments referencing those env vars (cmd/root.go, cmd/networkcmd/start.go, cmd/nodecmd/link.go) describe the constants-defined names accurately and are left alone. NOT renamed (script-local variables, not env vars): - LUX_ZONE in scripts/update-cloudflare-dns.sh (Cloudflare DNS zone ID) - LUX_BIN_DIR in scripts/install.sh (~/.lux/bin path constant) BREAKING: external callers/operators must update env var names. Per CLAUDE.md no-backwards-compatibility rule, the old forms are removed.
3 tasks
hanzo-dev
added a commit
that referenced
this pull request
May 16, 2026
…39) Picks up luxfi/constants@v1.5.4 which renames the 4 binary-path env var values: LUX_NODE_PATH -> NODE_PATH, LUX_NETRUNNER_PATH -> NETRUNNER_PATH, LUX_EVM_PATH -> EVM_PATH, LUX_PLUGINS_DIR -> PLUGINS_DIR. Constant identifiers (EnvNodePath etc) unchanged — only doc strings in root.go / networkcmd/start.go / nodecmd/link.go need a textual refresh. BREAKING: external operators / scripts setting LUX_NODE_PATH (etc.) must rename to the un-prefixed form. Completes the LUX_ prefix sweep started in #38 — the 4 constants-defined names were left for this follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop LUX_ prefix from env vars across cli — the brand prefix was noise:
LUX_MNEMONIC->MNEMONIC(deploy script + LLM doc)LUX_PRIVATE_KEY->PRIVATE_KEY(deploy script + LLM doc)LUX_INSECURE_TLS->INSECURE_TLSLUX_NODE_ENDPOINT->NODE_ENDPOINTLUX_NETWORK_TYPE->NETWORK_TYPE(backend gRPC server selector)LUX_RPC_URL->RPC_URLLUX_NODE_ROOT->NODE_ROOTLUX_CHART_PATH->CHART_PATHLUX_CHAINS_FILE->CHAINS_FILELUX_KMS_ROOT_KEY->KMS_ROOT_KEYLUX_WC_PROJECT_ID->WC_PROJECT_ID(WalletConnect)LUX_BLS_KEY->BLS_KEYLUX_KEY_INDEX->KEY_INDEXpkg/key/backend_env.go: removed the LUX_-prefix-strippinggetEnv()helper (now reads env vars by exact name) and cleaned up the broken
"MNEMONIC / MNEMONIC" / "PRIVATE_KEY / PRIVATE_KEY" doc comments
which were a previous incomplete rename.
Out of scope (separate PR — requires luxfi/constants bump)
LUX_NODE_PATH,LUX_NETRUNNER_PATH,LUX_EVM_PATH,LUX_PLUGINS_DIRare defined in upstreamluxfi/constantspackage(
repos.go). Doc comments referencing them by name are left intactbecause they describe the upstream-defined env var names accurately.
Out of scope (script-local variables, not env vars)
LUX_ZONEinscripts/update-cloudflare-dns.sh— Cloudflare DNS zone IDLUX_BIN_DIRinscripts/install.sh—~/.lux/binpath constantTest plan
go build ./...cleango test ./pkg/key/...passes (6.78s)go test ./cmd/nodecmd/ -run TestDefaultChartPathpasses(validates new
CHART_PATHenv handling)Breaking change
Per CLAUDE.md no-backwards-compatibility rule, the old
LUX_Xforms are removed. Callers/operators must update env var names.