deps: bump luxfi/api v1.0.10 -> v1.0.11 (Corona rename)#108
Merged
Conversation
Picks up ConsensusInfo.Ringtail -> ConsensusInfo.Corona rename so the service_test.go typecheck (TestGetNodeVersionConsensusRoundtrip) compiles. Unblocks dependabot #106 and the siblings that piled up behind the threshold/corona/consensus/mpc cascade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/luxfi/apifrom v1.0.10 to v1.0.11.ConsensusInfo.Ringtail->ConsensusInfo.Coronafield+JSON tag rename soservice/info/service_test.gotypechecks again.Why
The threshold/corona/consensus/mpc cascade landed everywhere except luxfi/api, leaving
apiinfo.ConsensusInfo{Corona: true}(used inTestGetNodeVersionConsensusRoundtrip) unresolved. luxfi/api#2 (merged) fixes the field; this PR cascades the bump.Unblocks dependabot PR #106 and likely siblings.
Test plan
go build ./...cleango test -count=1 ./service/info/...-> ok