ci: add minimal build+vet workflow + fix two test build errors#3
Merged
Conversation
- New .github/workflows/ci.yml runs `go build ./...` and `go vet` on the
packages whose tests currently compile (skips p/block/* and
x/txs/executor — those test stubs were absorbed from luxfi/proto and
need rework to satisfy current luxfi/validators.State and
github.com/luxfi/protocol/p/block/executor backend{} shape).
- Drop unused context import in x/txs/operation_test.go
- Extend semantic_verifier_test.go testValidatorState stub to satisfy
the full luxfi/validators.State surface (add GetCurrentValidators,
GetWarpValidatorSet, GetWarpValidatorSets; fix GetValidatorSet
signature to take context + return validators.GetValidatorOutput).
Tests in x/txs/executor still panic at runtime (secp256k1fx.Initialize
on nil codec registry — pre-existing, separate fix). Build is green;
ship the workflow so we have a baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlso this new repo has a CI signal (build + vet on packages whose tests compile)Tests in x/txs/executor still panic at runtime (secp256k1fx.Initialize on nil codec registry) — pre-existing in absorbed code, separate fix.
Test plan