Improve examples/calibration_reader.py #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x of the right camera
Collaborator
|
Thanks for the PR @nindanaoto |
saching13
approved these changes
Oct 14, 2021
Contributor
saching13
left a comment
saching13
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the piece of code to examples/calibration_reader.py to extract the distortion coefficients and the intrinsic matrix of the right camera.
Some users, like me, may use this code to extract the parameter of the camera quickly, so this may be helpful.