Added ubuntu-rolling to workflow #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakaskerl
commented
Mar 4, 2024
jakaskerl
commented
- Added ubuntu:rolling runner to workflow file to check dependency installation script and wheels.
- fixed dependencies for debian==11.9
moratom
reviewed
Mar 4, 2024
Comment on lines
+35
to
+45
| - name: Create a virtual environment | ||
| if: endsWith(matrix.container_image, 'rolling') == true | ||
| run: | | ||
| sudo apt-get install -y python3-venv | ||
| python3 -m venv venv | ||
| . venv/bin/activate | ||
| pip install --upgrade pip | ||
| python3 examples/install_requirements.py | ||
| shell: bash | ||
| - name: Install example requirements | ||
| if: endsWith(matrix.container_image, 'rolling') == false |
Collaborator
There was a problem hiding this comment.
Why the virtual environment only for rolling?
Collaborator
There was a problem hiding this comment.
(synced locally) seems like the latest ubuntu doesn't like messing with global python.
This also means that install_requriements.py likely on the latest ubuntu.
We'll see how the next LTS will handle this, but for now LGTM
moratom
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.