Skip to content

Added ubuntu-rolling to workflow #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Added ubuntu-rolling to workflow #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9468747
Added ubuntu-rolling to workflow
jakaskerl Mar 4, 2024
09cdd8d
Fixing wildcard matching
jakaskerl Mar 4, 2024
52f0fa4
Create custom venv for ubuntu 23.04
jakaskerl Mar 4, 2024
f260509
Install venv module
jakaskerl Mar 4, 2024
c9b1a4c
Changing source to '.'
jakaskerl Mar 4, 2024
95085a1
Forcing bash shell
jakaskerl Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/test-install-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
runs-on: ubuntu-latest
strategy:
matrix:
container_image: ["fedora:34", "fedora:35", "fedora:36", "ubuntu:18.04", "ubuntu:20.04", "ubuntu:22.04"]
container_image: ["fedora:34", "fedora:35", "fedora:36", "ubuntu:18.04", "ubuntu:20.04", "ubuntu:22.04", "ubuntu:rolling"]
container:
image: ${{ matrix.container_image }}
steps:
Expand All @@ -32,7 +32,17 @@
ln -snf /usr/share/zoneinfo/UTC /etc/localtime && echo UTC > /etc/timezone # Otherwise tzdata installer prompts for user input
sed '/udevadm control --reload-rules && sudo udevadm trigger/d' docs/source/_static/install_dependencies.sh > tmp_script.sh # Doesn't work on docker
bash tmp_script.sh
- name: Create a virtual environment
if: endsWith(matrix.container_image, 'rolling') == true
run: |
sudo apt-get install -y python3-venv
python3 -m venv venv
. venv/bin/activate
pip install --upgrade pip
python3 examples/install_requirements.py
shell: bash
- name: Install example requirements
if: endsWith(matrix.container_image, 'rolling') == false
Comment on lines +35 to +45
Copy link
Collaborator

@moratom moratom Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the virtual environment only for rolling?

Copy link
Collaborator

@moratom moratom Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(synced locally) seems like the latest ubuntu doesn't like messing with global python.

This also means that install_requriements.py likely on the latest ubuntu.

We'll see how the next LTS will handle this, but for now LGTM

run: |
python3 examples/install_requirements.py
test_macos:
Expand Down
8 changes: 4 additions & 4 deletions docs/source/_static/install_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,10 @@ elif [ -f /etc/os-release ]; then

if [ $IS_ARM ]; then
sudo DEBIAN_FRONTEND=noninteractive apt install -y "${debian_arm_pkgs[@]}"
if [ "$version" == "13" ]; then
if [[ $version == 13* ]]; then
echo "Detected ARM Debian 13"
sudo apt install -y "${debian_pkgs_23[@]}"
elif version_lte "$version" "11"; then
elif version_lte "$version" "11.99"; then
echo "Using pre-22.04 ARM package list"
sudo apt-get install -y ${debian_pkgs_pre22_04[@]}

Expand All @@ -214,10 +214,10 @@ elif [ -f /etc/os-release ]; then

else
sudo DEBIAN_FRONTEND=noninteractive apt install -y "${debian_pkgs[@]}"
if [ $version == "13" ]; then
if [[ $version == 13* ]]; then
echo "Detected Debian 13"
sudo apt install -y "${debian_pkgs_23[@]}"
elif version_lte "$version" "11"; then
elif version_lte "$version" "11.99"; then
echo "Using pre-22.04 package list"
sudo apt-get install -y "${debian_pkgs_pre22_04[@]}"

Expand Down