Skip to content

Support arbitrary zip layouts of calibration datasets#211

Merged
ptoupas merged 4 commits intomainfrom
fix/zip-extraction-layout
Mar 5, 2026
Merged

Support arbitrary zip layouts of calibration datasets#211
ptoupas merged 4 commits intomainfrom
fix/zip-extraction-layout

Conversation

@ptoupas
Copy link
Copy Markdown
Contributor

@ptoupas ptoupas commented Mar 5, 2026

Purpose

Fix zip extraction in to handle arbitrary archive layouts (non-nested, nested, and double-nested) when downloading calibration data.

Specification

  • Extraction now always targets a dedicated subfolder, preventing loose files from polluting the destination directory in the non-nested case.
  • Introduced _find_content_root, which walks down the extracted directory tree to the first level containing files, transparently handling any zip layout.

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

Tested with three zip layouts:

  • Non-nested (loose .npy files at zip root)
  • Nested with matching folder name
  • Nested with mismatched folder name

@ptoupas ptoupas requested a review from a team as a code owner March 5, 2026 08:00
@ptoupas ptoupas requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team March 5, 2026 08:00
@ptoupas ptoupas merged commit 92884db into main Mar 5, 2026
2 checks passed
@ptoupas ptoupas deleted the fix/zip-extraction-layout branch March 5, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants