Extra address-of operator in lv_disp_flush_ready(disp-driver)

[cjheath]

lvgl_esp32_drivers/lvgl_tft/disp_spi.c

Line 313 in 7d0bbe8

lv_disp_flush_ready(&disp->driver);

This line fails to compile for me, until I remove the ampersand.

[C47D]

Hi @cjheath , I think somebody else reported the same problem in another issue, what version of LVGL are you using? is it v8 by any chance?

[cjheath]

Yes, v8. Trying to follow the instructions for v7 not knowing there is a partially complete transition was very difficult - several days wasted chasing rabbits.

…

On Thu., 1 Jul. 2021, 13:46 Carlos Diaz, ***@***.***> wrote: Hi @cjheath <https://github.com/cjheath> , I think somebody else reported the same problem in another issue, what version of LVGL are you using? is it v8 by any chance? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAANJYPNH27S34OQ52KF63TVPQIDANCNFSM47TPAN5A> .

[C47D]

Yes, we haven't started the transition to v8 just yet, trying to fix all the issues before that, we just merged the fix.

[cjheath]

Yeah that's all fine, but I just followed ESP-IDF instructions to check out trunk of lvgl and lvgl_esp32_drivers using git submodules - and assumed that what was on trunk would be CI tested to build cleanly. It's not a criticism of your development process (I'm cool with trunk-based development, though it's unfashionable), but if there is a better way for newbies to get a stable build, it should be easier to find. If I can create or improve the "getting started" instructions, please give me a pointer so I can help others avoid the pain I went through.
It's also weird that it still seems necessary to edit lv_conf.h to set LV_HOR_RES_MAX/LV_VER_RES_MAX. It's not a very Kconfig thing to do. Is that also going away in v8?