[FIX] Move all implementation under include guard#6
Conversation
|
I think formatter off commit would be better since i could not understand which lines are changed. And i also love linux c style provided by .clang-format 😂 |
|
Ohhh I did not see the .clang-format file there, however, I am now running |
Sure I will open up a formatted pr to your repo |
|
Apparently, I cannot fork your repo since I already have an fbgl repo. but we can do it this way. I will open a branch called dev for you, not master, and you will assign your commit to the dev branch, and I will format the files in dev and merge them to the master branch. Or you can format it yourself using clang-format. here is the formatting process:
|
All function implementations are now under the #ifdef FBGL_IMPLEMENTATION guard, in order to prevent bugs as described by #3 (fixes task 3)
Commit also solves a double
#defineon theFBGL_MAX_KEYSmarcro. My formatter ran on the code and sorted the includes as well as applied general formattings to everything, if you want I can amend the commit with just the relevant update (and switch the formatter off)