Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
commented
Mar 20, 2023
Contributor
Author
|
GPT2 sentiment script: https://wandb.ai/distill-bloom/trl/runs/jvg0lxz7?workspace=user-younesbelkada |
Contributor
Author
lvwerra
approved these changes
Mar 21, 2023
Member
lvwerra
left a comment
lvwerra
left a comment
There was a problem hiding this comment.
One comment otherwise looks good to me!
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* refactor peft API * update gpt2 peft script * refactor * few fixes * fix bug * make style * update docs * more update * fix docs * fix issues and add tests * make style * update dcos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly refactors the way we use / load peft models
For now I think it is important to let users pass the
PeftConfigtofrom_pretrained, as it is an essential component for create peft modelsI also think that we should be able to pass
prepare_int8_trainingkwargs directly tofrom_pretrainedas well, since sometimes you need some tweaks to enable int8 trainingThis PR is also fully backward compatible with the previous API
cc @lvwerra