[core] Add warning when negative KL#239
Merged
younesbelkada merged 4 commits intomainfrom Mar 22, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
reviewed
Mar 22, 2023
Member
lvwerra
left a comment
lvwerra
left a comment
There was a problem hiding this comment.
Great idea, however it's the "objective/kl" that becomes negative with the wrong generation kwargs :)
Contributor
Author
|
Indeed! Just fixed it :D |
lvwerra
approved these changes
Mar 22, 2023
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* add warning * oops * fix * Update trl/trainer/ppo_trainer.py Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> --------- Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #235
The warning message will be displayed only once, if there is a repetition, as described in the official documentation of
warningspackage: https://docs.python.org/2/library/warnings.html / https://stackoverflow.com/questions/22661745/why-only-one-warning-in-a-loopcc @lvwerra