Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Thanks a lot for this!
THe proposed changes should fix the failing tests
Contributor
Author
|
Ah @younesbelkada the suggestion overwrote a needed variable. I'll fix it today, shouldn't be so bad :) |
natolambert
force-pushed
the
ppo_logging
branch
from
914c839 to
e59dc57
Compare
added 4 commits
March 23, 2023 09:32
Contributor
Author
|
feel free to merge when ready / happy @younesbelkada @lvwerra |
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* init pr * try and fix docpreview * fix * try to fix tests * nit * fix tests * convert to tensor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to make it clearer in experiments the difference between the reward model score and the KL penalty. Added PR to do that :).