Use float instead of double to avoid issues with MPS device#499
Merged
younesbelkada merged 1 commit intomainfrom Jul 6, 2023
Merged
Use float instead of double to avoid issues with MPS device#499younesbelkada merged 1 commit intomainfrom
float instead of double to avoid issues with MPS device#499younesbelkada merged 1 commit intomainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Member
|
Can you quickly run the IMDb example to check that we are not breaking anything? |
lvwerra
approved these changes
Jul 6, 2023
Contributor
Author
|
Sure yes, running it now, will merge after few steps and making sure it converges |
Contributor
Author
|
Here are the logs: https://wandb.ai/younesbelkada/trl/runs/zmimbndd?workspace=user- all seems good ! Merging! |
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #440 (comment)
We should use
floatinstead ofdoubleto avoid issues with MPS devicecc @lvwerra