[SFTTrainer] Fix the sequence length check of SFTTrainer#512
Merged
younesbelkada merged 4 commits intomainfrom Jul 12, 2023
Merged
[SFTTrainer] Fix the sequence length check of SFTTrainer#512younesbelkada merged 4 commits intomainfrom
SFTTrainer] Fix the sequence length check of SFTTrainer#512younesbelkada merged 4 commits intomainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Member
|
We should also set |
lvwerra
approved these changes
Jul 12, 2023
This was referenced Jul 12, 2023
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
…face#512) * fix the sequence length check of `SFTTrainer` * forward contrib credits from initial contribution * forward contrib credits from initial contribution * final comments --------- Co-authored-by: mrm8488 <mrm8488@users.noreply.github.com> Co-authored-by: BramVanroy <BramVanroy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #467
Replaces #481
The original code lead to having examples that were filtered out by the previous check. This ultimately lead to having examples being ignored when processing the data. Probably a copy-pasta from: https://huggingface.co/learn/nlp-course/chapter7/6?fw=pt where I borrowed the original code
The fix is to remove completely that check
cc @lvwerra